feat(core): import warns when source and destination directories are different #27875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1d61d67. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
jaysoo
force-pushed
the
feat/import-warn-on-different-dirs
branch
from
89746ad to
989d96a
Compare
jaysoo
force-pushed
the
feat/import-warn-on-different-dirs
branch
from
989d96a to
1d61d67
Compare
Coly010
approved these changes
Sep 11, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Sep 12, 2024
…different (#27875) This PR adds a warning when the user choose different source and destination roots. This is a problem for Nx workspaces using path options in `project.json`, and possibly other config files such as `tsconfig.json`, `jest.config.ts`, etc. Note: Also included a guard that the destination directory isn't an absolute path like `/tmp/foo`, because the behavior will not work as expected. The message when the source is an Nx workspace: <img width="1392" alt="Screenshot 2024-09-11 at 9 32 54 AM" src="https://github.com/user-attachments/assets/c8ebedba-fd66-4dbf-ada9-eacf86bd67fc"> The message when the source is not an Nx workspace: <img width="1392" alt="Screenshot 2024-09-11 at 9 30 44 AM" src="https://github.com/user-attachments/assets/ade9fbd1-4d5d-4d0c-93f6-eaad176af333"> (cherry picked from commit 8b177bd)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a warning when the user choose different source and destination roots. This is a problem for Nx workspaces using path options in
project.json, and possibly other config files such astsconfig.json,jest.config.ts, etc.Note: Also included a guard that the destination directory isn't an absolute path like
/tmp/foo, because the behavior will not work as expected.The message when the source is an Nx workspace:
The message when the source is not an Nx workspace:
